Unverified Commit 66646834 authored by Dimitris Koutsogiorgas's avatar Dimitris Koutsogiorgas Committed by GitHub

Merge pull request #7504 from dnkoutso/fix_test_spec_signing

Fix iOS test native target signing settings
parents e4355d85 abac7393
......@@ -55,6 +55,10 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
##### Bug Fixes
* Fix iOS test native target signing settings
[Dimitris Koutsogiorgas](https://github.com/dnkoutso)
[#7504](https://github.com/CocoaPods/CocoaPods/pull/7504)
* Clear input/output paths if they exceed an arbitrary limit
[Dimitris Koutsogiorgas](https://github.com/dnkoutso)
[#7362](https://github.com/CocoaPods/CocoaPods/issues/7362)
......
......@@ -278,7 +278,10 @@ module Pod
# irrelevant to whether we use frameworks or not.
configuration.build_settings['PRODUCT_NAME'] = name
# We must codesign iOS XCTest bundles that contain binary frameworks to allow them to be launchable in the simulator
configuration.build_settings['CODE_SIGNING_REQUIRED'] = 'YES' unless target.platform == :osx
unless target.platform == :osx
configuration.build_settings['CODE_SIGNING_REQUIRED'] = 'YES'
configuration.build_settings['CODE_SIGNING_ALLOWED'] = 'YES'
end
# For macOS we do not code sign the XCTest bundle because we do not code sign the frameworks either.
configuration.build_settings['CODE_SIGN_IDENTITY'] = '' if target.platform == :osx
end
......
......@@ -200,6 +200,7 @@ module Pod
native_test_target.build_configurations.each do |bc|
bc.build_settings['PRODUCT_NAME'].should == 'CoconutLib-Unit-Tests'
bc.build_settings['CODE_SIGNING_REQUIRED'].should == 'YES'
bc.build_settings['CODE_SIGNING_ALLOWED'].should == 'YES'
bc.build_settings['CODE_SIGN_IDENTITY'].should == 'iPhone Developer'
end
native_test_target.symbol_type.should == :unit_test_bundle
......@@ -216,6 +217,7 @@ module Pod
native_test_target.build_configurations.each do |bc|
bc.build_settings['PRODUCT_NAME'].should == 'CoconutLib-Unit-Tests'
bc.build_settings['CODE_SIGNING_REQUIRED'].should.be.nil
bc.build_settings['CODE_SIGNING_ALLOWED'].should.be.nil
bc.build_settings['CODE_SIGN_IDENTITY'].should == ''
end
native_test_target.symbol_type.should == :unit_test_bundle
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment