Commit f5218eff authored by Jacek Suliga's avatar Jacek Suliga

[Pods Project Generator] Improve performance by removing redundant processing…

[Pods Project Generator] Improve performance by removing redundant processing for native target dependencies
parent 5cffb44f
...@@ -11,6 +11,9 @@ To install release candidates run `[sudo] gem install cocoapods --pre` ...@@ -11,6 +11,9 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
* Improve performance of the dependency resolver by removing duplicates for dependency nodes. * Improve performance of the dependency resolver by removing duplicates for dependency nodes.
[Jacek Suliga](https://github.com/jmkk) [Jacek Suliga](https://github.com/jmkk)
* Improve performance of Pods project generator by skipping native targets for which dependent targets have already been added.
[Jacek Suliga](https://github.com/jmkk)
##### Bug Fixes ##### Bug Fixes
* Inhibit warnings for all dependencies during validation except for the one being validated * Inhibit warnings for all dependencies during validation except for the one being validated
......
...@@ -312,6 +312,10 @@ module Pod ...@@ -312,6 +312,10 @@ module Pod
end end
def add_dependent_targets_to_native_target(dependent_targets, native_target, is_app_extension, requires_frameworks, frameworks_group) def add_dependent_targets_to_native_target(dependent_targets, native_target, is_app_extension, requires_frameworks, frameworks_group)
@processed_native_targets ||= Set.new
return if @processed_native_targets.include? native_target
@processed_native_targets << native_target
dependent_targets.each do |pod_dependency_target| dependent_targets.each do |pod_dependency_target|
next unless pod_dependency_target.should_build? next unless pod_dependency_target.should_build?
native_target.add_dependency(pod_dependency_target.native_target) native_target.add_dependency(pod_dependency_target.native_target)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment